JSON subdictionary for setting initial conditions #1738
Conversation
|
Harry, there is probably a problem with the hemi in reframe. You have to change the case file template there. |
|
So you are just changing where the config for blasius is, right? I think that is good, since it is no longer shared between the bcs and the ics. |
|
btw, regarding Blasius in general: Should one not just add a correct Blasius profile? I would never use any of these approximations for a serious simulation. |
Yes please do! |
Thanks 👍 |
Yeh exactly (I actually just change it one more time such that it's more in line with the other ICs) |
| "approximation": "sin", | ||
| "delta": 0.6, | ||
| "freestream_velocity": [1.0, 0.0, 0.0] | ||
| }, | ||
| "inflow_condition": { |
There was a problem hiding this comment.
By the way, this can be removed, because it is not read anymore. This stuff should be directly in the boundary_conditions dict.
| call json_extract_object(this%params, 'case.fluid.initial_condition', & | ||
| json_subdict) |
There was a problem hiding this comment.
Unrelate to this PR, we should reasses as to why the case has to take care of fluids ics, and not fluid itself.
This PR introduces a json sub-dictionary instead of hard coding
case.fluidandcase.scalarto allow more re-usability offlow_icandscalar_ic.NOTE
There is a change to how the Blasius parameters enters case file, so I hope this doesn't cause an inconvenience to people already using this BC.